Skip to content

Add oversized values storage and retrieval#242

Draft
ianmacartney wants to merge 3 commits intomainfrom
ian/store-oversized-values
Draft

Add oversized values storage and retrieval#242
ianmacartney wants to merge 3 commits intomainfrom
ian/store-oversized-values

Conversation

@ianmacartney
Copy link
Copy Markdown
Member

@ianmacartney ianmacartney commented Apr 15, 2026

When a step result exceeds 1MB, store the full value in file storage
via an oversizedValues table so it can be retrieved later with
ctx.runAction(components.workflow.oversizedValues.read, { stepId }).

Adds list/read/remove public API, and cleans up stored values
when workflows are cleaned up.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 15, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ff70701d-2bf9-4ca4-a607-9065e93ebd9e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ian/store-oversized-values

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Member Author

ianmacartney commented Apr 15, 2026

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 15, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@convex-dev/workflow@242

commit: 005b95e

@ianmacartney ianmacartney reopened this Apr 15, 2026
@ianmacartney ianmacartney changed the base branch from ian/fail-oversized-steps to graphite-base/242 April 15, 2026 05:42
@ianmacartney ianmacartney changed the base branch from graphite-base/242 to ian/limit-step-value-size April 15, 2026 05:42
@ianmacartney ianmacartney changed the title save oversized step values to file storage for retrieval fail steps with oversized return values instead of getting stuck Apr 15, 2026
@ianmacartney ianmacartney marked this pull request as ready for review April 15, 2026 05:45
@ianmacartney ianmacartney marked this pull request as draft April 15, 2026 05:45
@ianmacartney ianmacartney changed the title fail steps with oversized return values instead of getting stuck Add oversized values storage and retrieval Apr 15, 2026
@ianmacartney ianmacartney force-pushed the ian/store-oversized-values branch from 58172fc to 777bef8 Compare April 15, 2026 05:51
@ianmacartney ianmacartney reopened this Apr 15, 2026
@ianmacartney ianmacartney force-pushed the ian/store-oversized-values branch from 777bef8 to 1e67365 Compare April 17, 2026 01:51
@ianmacartney ianmacartney force-pushed the ian/limit-step-value-size branch 2 times, most recently from 25a835e to 52b97d5 Compare April 17, 2026 03:43
@ianmacartney ianmacartney force-pushed the ian/store-oversized-values branch 4 times, most recently from cfe1c9d to a3188ba Compare April 24, 2026 02:29
@ianmacartney ianmacartney changed the base branch from ian/limit-step-value-size to graphite-base/242 April 27, 2026 22:49
@ianmacartney ianmacartney force-pushed the ian/store-oversized-values branch from a3188ba to 14237f9 Compare April 27, 2026 23:00
@ianmacartney ianmacartney changed the base branch from graphite-base/242 to main April 27, 2026 23:01
@ianmacartney ianmacartney force-pushed the ian/store-oversized-values branch from 14237f9 to 1b66bc7 Compare April 29, 2026 02:56
ianmacartney and others added 2 commits April 29, 2026 17:12
When a step result exceeds 1MB, store the full value in file storage
via an oversizedValues table so it can be retrieved later with
ctx.runAction(components.workflow.oversizedValues.read, { stepId }).

Adds list/read/remove public API, and cleans up stored values
when workflows are cleaned up.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ianmacartney ianmacartney force-pushed the ian/store-oversized-values branch from 623455f to 005b95e Compare April 30, 2026 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant