Slash div migration#425
Open
Ethan Tran (ethantran) wants to merge 2 commits into
Open
Conversation
Ethan Tran (ethantran)
requested review from
Chen Guo (ChirashiSushi),
Wesley Robinson (WesleyDRobinson),
coleEthos and
Harry (harrokun)
coleEthos
approved these changes
Dec 17, 2021
Collaborator
coleEthos
left a comment
coleEthos
left a comment
There was a problem hiding this comment.
I think this is okay. Couple questions Ethan Tran (@ethantran)
- Did you test consuming this new version of EDS in anything like main app or CMS? Want to make sure it's not a breaking change in anyway (shouldn't be from my understanding of sass:math). Is the
node-sasspackage where we getsass:mathfrom? - Should we also update
ethos-design-system/src/components/Select/Select.module.scss? I see 3line-heightdivision calculations in that file. - Once you're done and before merging, please make sure to also add the git tag for this version 1.3.0. I didn't see on here: https://github.com/getethos/ethos-design-system/tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To remove warnings from sass output, I had to run this migrator. https://sass-lang.com/documentation/breaking-changes/slash-div