Skip to content

New Color Added for EPLI#463

Draft
Chen Guo (ChirashiSushi) wants to merge 1 commit into
masterfrom
chen/color
Draft

New Color Added for EPLI#463
Chen Guo (ChirashiSushi) wants to merge 1 commit into
masterfrom
chen/color

Conversation

@ChirashiSushi
Copy link
Copy Markdown
Contributor

@ChirashiSushi Chen Guo (ChirashiSushi) commented Nov 1, 2022

Jira Task

Please review these reminders and either check the box or explain why not:

  • Read and followed the contributing guidelines?
  • Component is exported from index.js?
  • Type is exported from index.d.ts so Typescript users can consume it? Added a test and ran yarn test:types?
  • Bumped the yarn version?

Screenshots and extra notes:

Last 4 colors:
Untitled

@ChirashiSushi Chen Guo (ChirashiSushi) added the growth dev pull requests within the growth dev team label Nov 1, 2022
@ChirashiSushi Chen Guo (ChirashiSushi) changed the title New Color Added New Color Added for EPLI Nov 1, 2022
--BrandMoss--opaque: #f2f9f6;
--BrandDuckegg--translucent: #f2f7ff;
--BrandDuckegg--dark: #336cc3;
--Gold--translucent: #ffc24d;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these the same names design team is using in Figma?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still trying to confirm these with Kelly. These are placeholder names for now.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kelly and I have decided to hard-code these colors for EPLI for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

growth dev pull requests within the growth dev team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants