fix(removeQueue): add panic recovery and double-check for outbound removal #80
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds error handling and safety improvements to the removalQueue's checkPending method to prevent crashes and handle cases where outbounds are removed concurrently. The changes include panic recovery to prevent process crashes and a double-check to verify outbound existence before removal.
Key Changes
- Added panic recovery with defer/recover pattern to catch and log panics during outbound/endpoint removal operations
- Implemented a double-check mechanism to verify an outbound still exists in the manager before attempting removal
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
WendelHime
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds improved error handling and a safety check to the
removalQueue'scheckPendingmethod. The main goals are to prevent panics from crashing the process during outbound or endpoint removal, and to avoid attempting to remove outbounds that have already been deleted.Error handling and safety improvements:
deferblock with arecover()call to log any panic that occurs during outbound or endpoint removal, preventing the process from crashing.closes getlantern/engineering/issues/2896