feat: Add import/export device settings utils for PS5#43
Open
tustanivsky wants to merge 4 commits intomainfrom
Open
feat: Add import/export device settings utils for PS5#43tustanivsky wants to merge 4 commits intomainfrom
tustanivsky wants to merge 4 commits intomainfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Duplicate settings export logic bypasses new wrapper
- Replaced direct InvokeCommand('settingsexport') call with ExportSettings() method in PlayStation5Provider.GetDiagnostics().
Or push these changes by commenting:
@cursor push 844694767a
Preview (844694767a)
diff --git a/app-runner/Private/DeviceProviders/PlayStation5Provider.ps1 b/app-runner/Private/DeviceProviders/PlayStation5Provider.ps1
--- a/app-runner/Private/DeviceProviders/PlayStation5Provider.ps1
+++ b/app-runner/Private/DeviceProviders/PlayStation5Provider.ps1
@@ -191,7 +191,7 @@
# Run prospero-ctrl settings export
try {
$settingsFile = Join-Path $OutputDirectory "$datePrefix-settings.xml"
- $this.InvokeCommand('settingsexport', @($settingsFile))
+ $this.ExportSettings($settingsFile)
$results.Files += $settingsFile
Write-Debug "Settings exported to: $settingsFile"
} catch {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR adds two new public functions (
Export-DeviceSettingsandImport-DeviceSettings) that expose theprospero-ctrlsettings export and settings import commands for connected PlayStation 5 devkits.Key changes:
settingsimportcommand toPlayStation5ProviderExportSettings()andImportSettings()methods to the baseDeviceProviderclassExport-DeviceSettingsandImport-DeviceSettingspublic functionsRelated items:
#skip-changelog