feat(replay): Avoid StoreEnvelope in forward_store#5625
Open
tobias-wilfert wants to merge 9 commits intomasterfrom
Open
feat(replay): Avoid StoreEnvelope in forward_store#5625tobias-wilfert wants to merge 9 commits intomasterfrom
StoreEnvelope in forward_store#5625tobias-wilfert wants to merge 9 commits intomasterfrom
Conversation
Dav1dde
reviewed
Feb 10, 2026
tobias-wilfert
commented
Feb 12, 2026
Comment on lines
+38
to
+48
| // Size of the consumer message. We can be reasonably sure this won't overflow because | ||
| // of the request size validation provided by Nginx and Relay. | ||
| let mut payload_size = MESSAGE_METADATA_OVERHEAD; | ||
| payload_size += event.as_ref().map_or(0, |b| b.len()); | ||
| payload_size += video.as_ref().map_or(0, |b| b.len()); | ||
| payload_size += recording.len(); | ||
|
|
||
| if payload_size >= ctx.max_replay_message_size { | ||
| relay_log::debug!("replay_recording over maximum size."); | ||
| return Err(Error::TooLarge); | ||
| } |
Member
Author
There was a problem hiding this comment.
Validation copied from the store.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the
forward_storefor the replay processor to not useStoreEnvelopeand instead directly send typed messages to the store (which avoids unnecessary conversions).As part of that it moves the validation logic out of the store such that only logic left is some simple mapping.
Follow up to: #5580