feat(docs): Add filtering capability#395
Conversation
|
@cursor review |
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
🤖 This preview updates automatically when you update the PR. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
@cursor review |
There was a problem hiding this comment.
Nice! I gave the PR a try and filtering seems to work quite well. I think this is a pretty interesting approach because we render the entire list of attributes to static HTML and manually hide the ones not matching the filter criterion. A consequence of Astro being static-first and the filter component itself being the dynamic island. I think this is reasonable though. If we ever run into performance problems, we can convert the entire attributes list to be rendered as a svelte component but I don't think it's necessary to change this now. The Svelte component itself looks good to me!
Had a couple of nits and one visual request:
can we show "x/N attributes" instead of "N Attributes" on these labels?
All feedback addressed, and added in that change for categories, though it will only show when we're rending the entire list. If a user has a selected category we leave it blank. |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 13756e7. Configure here.
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Nice, thanks for making the changes! I think the failing CI job comes from formatting. Might need to run yarn format again. 🚀
Reuse formatAttributeCount and add formatCategoryCount so counts of 1 read correctly. Co-authored-by: Cursor <cursoragent@cursor.com>
Search only needs key, brief, type, category, url, and deprecated; PII, visibility, and OTel filtering live on the attribute pages. Co-authored-by: Cursor <cursoragent@cursor.com>
Deep links to default-hidden cards stayed invisible after filter hydration; also open collapsed deprecated sections and re-scroll on hash change. Co-authored-by: Cursor <cursoragent@cursor.com>
nsdeschenes
force-pushed
the
nd/feat-docs-add-filtering-capability
branch
from
088a703 to
8247f26
Compare
2 participants
Description
This PR adds in some selects to filter out attributes based off of different key fields that appear on attributes. You are also able to mix and match these filters to narrow down attributes even further.
These changes were done up by Codex and myself, everything seems to be working a-okay, but I'm not the best at Svelte 🫣