Skip to content

feat(attributes): Add db.stored_procedure.name and ensure span name attribute consistency#398

Open
Lms24 wants to merge 3 commits into
mainfrom
lms/feat-attrs-span-name-consistency
Open

feat(attributes): Add db.stored_procedure.name and ensure span name attribute consistency#398
Lms24 wants to merge 3 commits into
mainfrom
lms/feat-attrs-span-name-consistency

Conversation

@Lms24
Copy link
Copy Markdown
Member

@Lms24 Lms24 commented May 21, 2026

I noticed that the db.stored_procedure.name attribute mentioned in the db span name template wasn't documented in conventions yet. This PR adds the attribute and a test that ensures that any attribute mentioned in span name templates exists as an attribute in conventions.

@Lms24 Lms24 requested review from a team, cleptric, mjq and nsdeschenes as code owners May 21, 2026 08:50
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • (attributes) Add db.stored_procedure.name and ensure span name attribute consistency by Lms24 in #398
  • (schema) Add additional_context field to attribute definitions by matejminar in #393

🤖 This preview updates automatically when you update the PR.

@Lms24 Lms24 self-assigned this May 21, 2026
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f84ce4b. Configure here.

Comment thread model/attributes/db/db__stored_procedure__name.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant