Skip to content

feat(metrics): [Trace Metrics 30] Create MetricsUnit constants #5025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
adinauer wants to merge 2 commits into
base: 01-13-rename_sample_api_param_remove_sleep
Choose a base branch
from
Draft

feat(metrics): [Trace Metrics 30] Create MetricsUnit constants #5025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81e4b6a
Create MetricsUnit constants
adinauer Jan 13, 2026
735f8f1
Format code
getsentry-bot Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...sentry-samples-spring-7/src/main/java/io/sentry/samples/spring7/web/MetricController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package io.sentry.samples.spring7.web;

import io.sentry.Sentry;
import io.sentry.metrics.MetricsUnit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.web.bind.annotation.GetMapping;
Expand All @@ -21,13 +22,14 @@ String count() {

@GetMapping("gauge/{value}")
String gauge(@PathVariable("value") Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), "byte");
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
return "gauge metric tracked";
}

@GetMapping("distribution/{value}")
String distribution(@PathVariable("value") Long value) {
Sentry.metrics().distribution("distributionMetric", value.doubleValue(), "child");
Sentry.metrics()
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
return "distribution metric tracked";
}
}
10 changes: 6 additions & 4 deletions ...-opentelemetry-noagent/src/main/java/io/sentry/samples/spring/boot4/MetricController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package io.sentry.samples.spring.boot4;

import io.sentry.Sentry;
import io.sentry.metrics.MetricsUnit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.web.bind.annotation.GetMapping;
Expand All @@ -20,14 +21,15 @@ String count() {
}

@GetMapping("gauge/{value}")
String gauge(@PathVariable Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), "byte");
String gauge(@PathVariable("value") Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
return "gauge metric tracked";
}

@GetMapping("distribution/{value}")
String distribution(@PathVariable Long value) {
Sentry.metrics().distribution("distributionMetric", value.doubleValue(), "child");
String distribution(@PathVariable("value") Long value) {
Sentry.metrics()
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
return "distribution metric tracked";
}
}
10 changes: 6 additions & 4 deletions ...g-boot-4-opentelemetry/src/main/java/io/sentry/samples/spring/boot4/MetricController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package io.sentry.samples.spring.boot4;

import io.sentry.Sentry;
import io.sentry.metrics.MetricsUnit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.web.bind.annotation.GetMapping;
Expand All @@ -20,14 +21,15 @@ String count() {
}

@GetMapping("gauge/{value}")
String gauge(@PathVariable Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), "byte");
String gauge(@PathVariable("value") Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
return "gauge metric tracked";
}

@GetMapping("distribution/{value}")
String distribution(@PathVariable Long value) {
Sentry.metrics().distribution("distributionMetric", value.doubleValue(), "child");
String distribution(@PathVariable("value") Long value) {
Sentry.metrics()
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
return "distribution metric tracked";
}
}
10 changes: 6 additions & 4 deletions ...-spring-boot-4-webflux/src/main/java/io/sentry/samples/spring/boot4/MetricController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package io.sentry.samples.spring.boot4;

import io.sentry.Sentry;
import io.sentry.metrics.MetricsUnit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.web.bind.annotation.GetMapping;
Expand All @@ -20,14 +21,15 @@ String count() {
}

@GetMapping("gauge/{value}")
String gauge(@PathVariable Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), "byte");
String gauge(@PathVariable("value") Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
return "gauge metric tracked";
}

@GetMapping("distribution/{value}")
String distribution(@PathVariable Long value) {
Sentry.metrics().distribution("distributionMetric", value.doubleValue(), "child");
String distribution(@PathVariable("value") Long value) {
Sentry.metrics()
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
return "distribution metric tracked";
}
}
10 changes: 6 additions & 4 deletions ...-samples-spring-boot-4/src/main/java/io/sentry/samples/spring/boot4/MetricController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package io.sentry.samples.spring.boot4;

import io.sentry.Sentry;
import io.sentry.metrics.MetricsUnit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.web.bind.annotation.GetMapping;
Expand All @@ -20,14 +21,15 @@ String count() {
}

@GetMapping("gauge/{value}")
String gauge(@PathVariable Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), "byte");
String gauge(@PathVariable("value") Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
return "gauge metric tracked";
}

@GetMapping("distribution/{value}")
String distribution(@PathVariable Long value) {
Sentry.metrics().distribution("distributionMetric", value.doubleValue(), "child");
String distribution(@PathVariable("value") Long value) {
Sentry.metrics()
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
return "distribution metric tracked";
}
}
10 changes: 6 additions & 4 deletions ...lemetry-noagent/src/main/java/io/sentry/samples/spring/boot/jakarta/MetricController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package io.sentry.samples.spring.boot.jakarta;

import io.sentry.Sentry;
import io.sentry.metrics.MetricsUnit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.web.bind.annotation.GetMapping;
Expand All @@ -20,14 +21,15 @@ String count() {
}

@GetMapping("gauge/{value}")
String gauge(@PathVariable Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), "byte");
String gauge(@PathVariable("value") Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
return "gauge metric tracked";
}

@GetMapping("distribution/{value}")
String distribution(@PathVariable Long value) {
Sentry.metrics().distribution("distributionMetric", value.doubleValue(), "child");
String distribution(@PathVariable("value") Long value) {
Sentry.metrics()
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
return "distribution metric tracked";
}
}
10 changes: 6 additions & 4 deletions ...a-opentelemetry/src/main/java/io/sentry/samples/spring/boot/jakarta/MetricController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package io.sentry.samples.spring.boot.jakarta;

import io.sentry.Sentry;
import io.sentry.metrics.MetricsUnit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.web.bind.annotation.GetMapping;
Expand All @@ -20,14 +21,15 @@ String count() {
}

@GetMapping("gauge/{value}")
String gauge(@PathVariable Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), "byte");
String gauge(@PathVariable("value") Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
return "gauge metric tracked";
}

@GetMapping("distribution/{value}")
String distribution(@PathVariable Long value) {
Sentry.metrics().distribution("distributionMetric", value.doubleValue(), "child");
String distribution(@PathVariable("value") Long value) {
Sentry.metrics()
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
return "distribution metric tracked";
}
}
10 changes: 6 additions & 4 deletions ...ng-boot-jakarta/src/main/java/io/sentry/samples/spring/boot/jakarta/MetricController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package io.sentry.samples.spring.boot.jakarta;

import io.sentry.Sentry;
import io.sentry.metrics.MetricsUnit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.web.bind.annotation.GetMapping;
Expand All @@ -20,14 +21,15 @@ String count() {
}

@GetMapping("gauge/{value}")
String gauge(@PathVariable Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), "byte");
String gauge(@PathVariable("value") Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
return "gauge metric tracked";
}

@GetMapping("distribution/{value}")
String distribution(@PathVariable Long value) {
Sentry.metrics().distribution("distributionMetric", value.doubleValue(), "child");
String distribution(@PathVariable("value") Long value) {
Sentry.metrics()
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
return "distribution metric tracked";
}
}
10 changes: 6 additions & 4 deletions ...t-opentelemetry-noagent/src/main/java/io/sentry/samples/spring/boot/MetricController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package io.sentry.samples.spring.boot;

import io.sentry.Sentry;
import io.sentry.metrics.MetricsUnit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.web.bind.annotation.GetMapping;
Expand All @@ -20,14 +21,15 @@ String count() {
}

@GetMapping("gauge/{value}")
String gauge(@PathVariable Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), "byte");
String gauge(@PathVariable("value") Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
return "gauge metric tracked";
}

@GetMapping("distribution/{value}")
String distribution(@PathVariable Long value) {
Sentry.metrics().distribution("distributionMetric", value.doubleValue(), "child");
String distribution(@PathVariable("value") Long value) {
Sentry.metrics()
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
return "distribution metric tracked";
}
}
10 changes: 6 additions & 4 deletions ...ring-boot-opentelemetry/src/main/java/io/sentry/samples/spring/boot/MetricController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package io.sentry.samples.spring.boot;

import io.sentry.Sentry;
import io.sentry.metrics.MetricsUnit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.web.bind.annotation.GetMapping;
Expand All @@ -20,14 +21,15 @@ String count() {
}

@GetMapping("gauge/{value}")
String gauge(@PathVariable Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), "byte");
String gauge(@PathVariable("value") Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
return "gauge metric tracked";
}

@GetMapping("distribution/{value}")
String distribution(@PathVariable Long value) {
Sentry.metrics().distribution("distributionMetric", value.doubleValue(), "child");
String distribution(@PathVariable("value") Long value) {
Sentry.metrics()
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
return "distribution metric tracked";
}
}
10 changes: 6 additions & 4 deletions ...webflux-jakarta/src/main/java/io/sentry/samples/spring/boot/jakarta/MetricController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package io.sentry.samples.spring.boot.jakarta;

import io.sentry.Sentry;
import io.sentry.metrics.MetricsUnit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.web.bind.annotation.GetMapping;
Expand All @@ -20,14 +21,15 @@ String count() {
}

@GetMapping("gauge/{value}")
String gauge(@PathVariable Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), "byte");
String gauge(@PathVariable("value") Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
return "gauge metric tracked";
}

@GetMapping("distribution/{value}")
String distribution(@PathVariable Long value) {
Sentry.metrics().distribution("distributionMetric", value.doubleValue(), "child");
String distribution(@PathVariable("value") Long value) {
Sentry.metrics()
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
return "distribution metric tracked";
}
}
10 changes: 6 additions & 4 deletions ...les-spring-boot-webflux/src/main/java/io/sentry/samples/spring/boot/MetricController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package io.sentry.samples.spring.boot;

import io.sentry.Sentry;
import io.sentry.metrics.MetricsUnit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.web.bind.annotation.GetMapping;
Expand All @@ -20,14 +21,15 @@ String count() {
}

@GetMapping("gauge/{value}")
String gauge(@PathVariable Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), "byte");
String gauge(@PathVariable("value") Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
return "gauge metric tracked";
}

@GetMapping("distribution/{value}")
String distribution(@PathVariable Long value) {
Sentry.metrics().distribution("distributionMetric", value.doubleValue(), "child");
String distribution(@PathVariable("value") Long value) {
Sentry.metrics()
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
return "distribution metric tracked";
}
}
10 changes: 6 additions & 4 deletions ...try-samples-spring-boot/src/main/java/io/sentry/samples/spring/boot/MetricController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package io.sentry.samples.spring.boot;

import io.sentry.Sentry;
import io.sentry.metrics.MetricsUnit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.web.bind.annotation.GetMapping;
Expand All @@ -20,14 +21,15 @@ String count() {
}

@GetMapping("gauge/{value}")
String gauge(@PathVariable Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), "byte");
String gauge(@PathVariable("value") Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
return "gauge metric tracked";
}

@GetMapping("distribution/{value}")
String distribution(@PathVariable Long value) {
Sentry.metrics().distribution("distributionMetric", value.doubleValue(), "child");
String distribution(@PathVariable("value") Long value) {
Sentry.metrics()
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
return "distribution metric tracked";
}
}
6 changes: 4 additions & 2 deletions ...s-spring-jakarta/src/main/java/io/sentry/samples/spring/jakarta/web/MetricController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package io.sentry.samples.spring.jakarta.web;

import io.sentry.Sentry;
import io.sentry.metrics.MetricsUnit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.web.bind.annotation.GetMapping;
Expand All @@ -21,13 +22,14 @@ String count() {

@GetMapping("gauge/{value}")
String gauge(@PathVariable("value") Long value) {
Sentry.metrics().gauge("memory.free", value.doubleValue(), "byte");
Sentry.metrics().gauge("memory.free", value.doubleValue(), MetricsUnit.Information.BYTE);
return "gauge metric tracked";
}

@GetMapping("distribution/{value}")
String distribution(@PathVariable("value") Long value) {
Sentry.metrics().distribution("distributionMetric", value.doubleValue(), "child");
Sentry.metrics()
.distribution("distributionMetric", value.doubleValue(), MetricsUnit.Duration.MILLISECOND);
return "distribution metric tracked";
}
}
Loading
Loading