macOS: convert clipboard confirmation to an alert#12736
Open
bo2themax wants to merge 2 commits into
Open
Conversation
bo2themax
force-pushed
the
push-cafc4418
branch
2 times, most recently
from
13d8c73 to
154fe8e
Compare
bo2themax
force-pushed
the
push-cafc4418
branch
2 times, most recently
from
5d268c4 to
53d22e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
ClipboardConfirmationViewinvolves few workarounds, based on the fact thatSwiftUI.TextEditordoesn't offer selectable but not editable api. By converting it to an NSAlert, we can benefit from NSTextView and we can clean up some xibs and add help button more easily.I checked with #1516, it's still fixed.