Conversation
gigamonkey
left a comment
gigamonkey
left a comment
There was a problem hiding this comment.
Make sure it runs then request another review.
| set -euo pipefail | ||
|
|
||
| # shellcheck source=/dev/null | ||
| source "$(dirname "$0")/lebron-line.sh" |
There was a problem hiding this comment.
This is weird. You are loading this file again from itself which is going to go into an infinite loop. Add
set -xbefore this line and try to run it to see. (You can cd build and then run ./lebron-line.sh foo. You'll probably need to chmod +x lebron-line.sh too which is something you should do anyway.
(Oh, I think you were trying to copy the line from the other lines-based script. If so you should have copied it exactly:
source "$(dirname "$0")/lines.sh"The point of that is to get all the functions defined in lines.sh that you want to use like ensure_lines, etc.
So that tells me you never actually ran this script. Either by itself or by adding it to the STEPS file and running make build. So you should make sure this actually runs and then request another review.
2 participants
made a lebron puzzle that requires some ball knowledge but very limited