Skip to content

remove bidirectional flow keys in flow table#1295

Merged
Fredi-raspall merged 2 commits intopr/fredi/port-forwardingfrom
pr/fredi/flow-entry-remove-bidirectional-keys-rebased
Feb 19, 2026
Merged

remove bidirectional flow keys in flow table#1295
Fredi-raspall merged 2 commits intopr/fredi/port-forwardingfrom
pr/fredi/flow-entry-remove-bidirectional-keys-rebased

Conversation

@Fredi-raspall
Copy link
Contributor

@Fredi-raspall Fredi-raspall commented Feb 18, 2026 •
edited
Loading

Partially fixes #1293

@Fredi-raspall
feat(flow-entry): remove bidirectional flow keys
5012332 
* Removes Bidirectional flow keys.
* Only one type of key remains (unidirectional), but this commit
  does not remove the variant in case other types of keys are
  supported in the future and so as not to break the api.

Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
@Fredi-raspall Fredi-raspall requested a review from a team as a code owner February 18, 2026 19:46
qmonnet
qmonnet requested changes Feb 19, 2026
View reviewed changes
@Fredi-raspall
feat(flow-entry): remove trait SrcLeqDst
6098287 
The trait and its implementations were only used in the context
of bidirectional keys, which have been removed.

Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
qmonnet
qmonnet approved these changes Feb 19, 2026
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@qmonnet
Copy link
Member

qmonnet commented Feb 19, 2026

Looks ready to merge, although I expect VLAB tests to fail in the merge queue at the moment (I'm looking into it)

@Fredi-raspall
Copy link
Contributor Author

Fredi-raspall commented Feb 19, 2026

Looks ready to merge, although I expect VLAB tests to fail in the merge queue at the moment (I'm looking into it)

I did not fail since the target is not master.

@qmonnet
Copy link
Member

qmonnet commented Feb 19, 2026 •
edited
Loading

I did not fail since the target is not master.

It did not fail because we don't currently run VLAB tests on the PR, only in the merge queue 🙂.

@qmonnet
Copy link
Member

qmonnet commented Feb 19, 2026

Actually you're right as well, given that you don't target main this PR might will not go through the merge queue to be merged into its main branch, my bad.

Do we want to merge it, then, or do we wait until we've merged the rest of the port-forwarding into the branch?

@Fredi-raspall Fredi-raspall merged commit 6098287 into pr/fredi/port-forwarding Feb 19, 2026
5 checks passed
@Fredi-raspall Fredi-raspall deleted the pr/fredi/flow-entry-remove-bidirectional-keys-rebased branch February 19, 2026 17:52
@Fredi-raspall
Copy link
Contributor Author

Fredi-raspall commented Feb 19, 2026

Actually you're right as well, given that you don't target main this PR might will not go through the merge queue to be merged into its main branch, my bad.

Do we want to merge it, then, or do we wait until we've merged the rest of the port-forwarding into the branch?

I just merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mvachhar mvachhar mvachhar approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Fredi-raspall @qmonnet @mvachhar

Comments