ci: Remove broken parameter for run-vlab.yaml workflow, disable VLAB upgrade tests#1298
Merged
ci: Remove broken parameter for run-vlab.yaml workflow, disable VLAB upgrade tests#1298
Conversation
The run-vlab.yml workflow that we pull from the Fabricator repository
recently removed the deprecated "gateway_agentless" argument for the
workflow (Fabricator commit afd17dc75f1a ("chore: do not pass agentless
flag as it's noop")). As a result, our workflow in dataplane is
currently broken:
Invalid workflow file: .github/workflows/dev.yml#L442
The workflow is not valid. .github/workflows/dev.yml (Line: 442, Col: 26): Invalid input, gateway_agentless is not defined in the referenced workflow.
Remove the parameter to fix the workflow.
Link: githedgehog/fabricator@afd17dc
Signed-off-by: Quentin Monnet <qmo@qmon.net>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Turn off upgrade tests for the CI, in particular for the merge queue. Sergei reports that these are currently broken and not supported for tests running with the gateway. We'll re-enable them in the future. Signed-off-by: Quentin Monnet <qmo@qmon.net>
qmonnet
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The run-vlab.yml workflow that we pull from the Fabricator repository recently removed the deprecated "gateway_agentless" argument for the workflow (Fabricator commit afd17dc75f1a ("chore: do not pass agentless flag as it's noop")). As a result, our workflow in dataplane is currently broken:
Remove the parameter to fix the workflow.
Link: githedgehog/fabricator@afd17dc
In a second commit, we disable VLAB upgrade tests: Sergei reports they're not currently working (or supported) for tests running with the gateway.