Skip to content

Fix path problem locations in .expected for 8-1-1, 8-1-2 #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbaluda merged 3 commits into from
Feb 25, 2026
Merged

Fix path problem locations in .expected for 8-1-1, 8-1-2 #1057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
836178f
Fix path problem locations in .expected for 8-1-1, 8-1-2
MichaelRFairhurst Feb 24, 2026
1dc9e5e
Update copilot review instructions
MichaelRFairhurst Feb 25, 2026
d2d8d6b
Merge branch 'main' into michaelrfairhurst/fix-path-problem-nodes-fro…
mbaluda Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/copilot-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,5 +55,6 @@ When reviewing tests, it is critical to:
- Check that there are no `.expected` rows that refer to test code cases marked as `COMPLIANT`, or with no comment
- Note that it is OK if the locations of the comment are not precisely aligned with the alert
- Check that the alert message and placeholders are accurate and understandable.
- Check that the locations do not refer to files in the standard library, as these have issues in GitHub's Code Scanning UI and complicate our compiler compatibility tests.
- Consider the "test coverage" of the query, are each of its logical statements effectively exercised individually, collectively? The test should neither be overly bloated nor under specified.
- Consider the edge cases of the language itself, will the analysis work in non-trivial cases, are all relevant language concepts tested here? This doesn't need to be exhaustive, but it should be thoughfully thorough.
Loading
Loading