Rust: Replace QL model for Clone with MaD#20124
Merged
geoffw0 merged 3 commits intogithub:mainfrom Jul 25, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the QL-based model for the Clone trait with a models-as-data (MaD) approach, making the codebase smaller, cleaner, and easier to maintain. The refactoring migrates from imperative QL code to a declarative YAML configuration.
Key changes:
- Adds a generic MaD model for
<_ as core::clone::Clone>::clonein the YAML model file - Removes the dedicated QL implementation file
Clone.qll - Updates imports to remove references to the deleted QL module
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lang-core.model.yml | Adds MaD model entry for the Clone trait |
| Clone.qll | Removes the entire QL-based implementation |
| Frameworks.qll | Removes import of the deleted Clone module |
| inline-flow.expected | Updates test expectations to reflect the new MaD model numbering |
paldepind
previously approved these changes
Jul 25, 2025
Contributor
paldepind
left a comment
paldepind
left a comment
There was a problem hiding this comment.
CI has some diffs, but LGTM 👍
paldepind
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the QL model for
Clonewith a models-as-data model. Smaller, cleaner, easier to maintain.