Draft
Conversation
tausbn
force-pushed
the
tausbn/python-add-dataflow-overlay-annotations
branch
from
e203d8b to
97e2376
Compare
tausbn
force-pushed
the
tausbn/python-add-dataflow-overlay-annotations
branch
from
97e2376 to
9e43da9
Compare
... and everything else that it depends on.
None of these required any changes to the dataflow libraries, so it seemed easiest to put them in their own commit.
These were causing the repo `gufolabs/noc` to spend ~30 seconds evaluating `ControlFlowNode.strictlyDominates`. Just in case, I added `overlay[caller] to the other instances of `pragma[inline]` as well.
On `keras-team/keras`, this was producing ~200 million intermediate tuples in order to produce a total of ... 2 tuples. After the refactor, max intermediate tuple count is ~80k for the charpred (and 4 for the new helper predicate).
This caused a ~30x blowup in intermediate tuples, now back to baseline.
tausbn
force-pushed
the
tausbn/python-add-dataflow-overlay-annotations
branch
from
c949417 to
304cd12
Compare
Two related fixes. First, I removed the pragmas from `appliesTo`, as these were actually causing a huge cartesian product to be created in `RangeIterationVariableFact.pointsTo` and `ReModulePointToExtension.pointsTo`. On `python/cpython`, at least, this caused a reduction of tuples from ~2.7 billion to ~2 billion. However this also caused `PointsToContext.fromCall/2` to get a worse join-order, so I inlined the definition and added a pragma _there_, and that fixed the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP