Skip to content

Improve Ruby guide #15240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ramyaparimi merged 7 commits into from
Feb 14, 2022
Merged

Improve Ruby guide #15240

ramyaparimi merged 7 commits into from
Feb 14, 2022

Conversation

@dentarg
Copy link
Contributor

@dentarg dentarg commented Feb 8, 2022 •
edited
Loading

Why:

Closes #13418

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@dentarg
Improve Ruby guide
35f625a 
- The wildcard doesn't work in setup-ruby
- Update to the latest version of setup-ruby: https://github.com/ruby/setup-ruby/releases/tag/v1.97.0
@dentarg
Copy link
Contributor Author

dentarg commented Feb 8, 2022

I did this because the previous version referenced, v1.75.0 (ruby/setup-ruby@477b21f), does not support Ruby 3.1.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 8, 2022
@dentarg dentarg mentioned this pull request Feb 8, 2022
Closed
5 tasks
@github-actions github-actions bot temporarily deployed to docs-15240--ruby-guide-patch February 8, 2022 09:13 Inactive
@github-actions github-actions bot temporarily deployed to docs-15240--ruby-guide-patch February 8, 2022 11:07 Inactive
eregon
eregon reviewed Feb 8, 2022
View reviewed changes
Copy link

@eregon eregon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@ramyaparimi ramyaparimi added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Feb 8, 2022
@ramyaparimi
Copy link
Contributor

ramyaparimi commented Feb 8, 2022

@dentarg
Thanks so much for opening a PR! I'll get this triaged for review ⚡

skedwards88
skedwards88 approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! We'll get this merged down for you.

@skedwards88 skedwards88 added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Feb 11, 2022
@ramyaparimi ramyaparimi merged commit d689159 into github:main Feb 14, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@dentarg dentarg deleted the ruby-guide-patch branch February 14, 2022 18:27
@dentarg
Copy link
Contributor Author

dentarg commented Apr 25, 2022

@skedwards88 regarding #15240 (comment)

I really like this idea. I'm working with the product team on the wording (since we recommend using the SHA for security reasons).

I don't want to hold up your PR while I wait on a response. For now, I am going to remove this. Once the wording is settled, we'll add a similar comment to this and other examples.

Has there been any development in this area? Allowing this comment or even allowing the starter workflow and/or the docs to reference ruby/setup-ruby@v1? It is a recurring confusion/problem users run into: ruby/setup-ruby#319

@dentarg dentarg mentioned this pull request Apr 25, 2022
Closed
@skedwards88
Copy link
Contributor

skedwards88 commented Apr 25, 2022

Thanks for following up! I followed up with the product team and opened an internal issue, but we haven't had time to implement it. I just moved the issue to the open source repo (#17365), so you or anyone else is welcome to make the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@eregon eregon eregon left review comments

@skedwards88 skedwards88 skedwards88 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dentarg @ramyaparimi @skedwards88 @eregon