Skip to content

Conversation

@jamesmontemagno
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings February 27, 2025 21:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates the README file to remove specific .NET version references and fix the repository clone URL.

  • Removed ".NET 8" references from the main header and descriptive text.
  • Changed the repository clone URL from a personal repository (bradygaster) to the official GitHub repository.

Reviewed Changes

File Description
readme.md Updated version references and fixed the repository clone URL

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

readme.md:1

  • The header now omits specific version information; if the intent is to update to .NET 9 as indicated by the PR title, consider explicitly including '.NET 9' for clarity.
# GitHub Codespaces ♥️ .NET

readme.md:5

  • The change from 'Minimal APIs' to ' .NET APIs' makes the description vague; if a specific API technology is intended (such as Minimal APIs or .NET 9 features), please clarify the text accordingly.
This repo builds a Weather API using .NET APIs, opens Swagger so you can call and test the API, and displays the data in a web application using Blazor with .NET.

readme.md:17

  • The updated clone URL changes from the personal repository to 'github/dotnet-codespace'. Please verify that this is the correct and intended repository location.
1. Clone the repo to your local machine `git clone https://github.com/github/dotnet-codespace`

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

Copy link
Collaborator

@timheuer timheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think since we moved away from swashbuckle we may want to be consistent. but if keeping the openapi browser in there, i'd swithc to Scalar (Scalar.AspnetCore) which means 2 more lines in program.cs and changing the launch URI to /scalar/v1 as the default

Specifically in csproj add package ref:

<PackageReference Include="Scalar.AspNetCore" Version="2.0.18" />

in program.cs:

using Scalar.AspNetCore;

// other code

if (app.Environment.IsDevelopment())
{
    app.MapOpenApi();
    app.MapScalarApiReference();
}

in launchSettings.json

"launchUrl": "scalar/v1"

Copy link
Collaborator

@timheuer timheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@timheuer timheuer merged commit b620abc into github:main Feb 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants