Closed
Conversation
Contributor
|
Hey @AngerM did you see my comment at #739 (comment) ?
Are we able to ignore those changes and move to upstream? Some of them seemed important. |
Author
|
The only one that I noticed was the gcfg |
demianstack6
approved these changes
May 30, 2021
demianstack6
approved these changes
May 31, 2021
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #739
This moves away from the vendored dependencies and switches to go modules, as well as adding a Dockerfile that contains the
gh-ostexecutable.The only side-effect was the
RelaxedParserModethat you guys had made changes for directly in your vendored version (as opposed to forking it). I dropped the one place that was used. If it's still desired, it would be best to fully fork the gcfg package and make the changes there.