Skip to content

Revert "Reduce fetch depth to 1" #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityasaky merged 1 commit into from
Mar 6, 2026
Merged

Revert "Reduce fetch depth to 1" #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions internal/webhook/webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import (
githubopts "github.com/gittuf/gittuf/experimental/gittuf/options/github"
rslopts "github.com/gittuf/gittuf/experimental/gittuf/options/rsl"
verifymergeableopts "github.com/gittuf/gittuf/experimental/gittuf/options/verifymergeable"
"github.com/gittuf/gittuf/pkg/gitinterface"
"github.com/go-git/go-git/v5"
"github.com/go-git/go-git/v5/plumbing"
"github.com/google/go-github/v61/github"
Expand Down Expand Up @@ -270,7 +269,7 @@ func (g *GittufApp) handlePush(ctx context.Context, event *github.PushEvent) err
if err != nil {
return err
}
if _, err := git.PlainClone(localDirectory, false, &git.CloneOptions{URL: cloneURL, Depth: 1}); err != nil {
if _, err := git.PlainClone(localDirectory, false, &git.CloneOptions{URL: cloneURL}); err != nil {
log.Default().Printf("Unable to clone repository: %v", err)
return err
}
Expand All @@ -289,7 +288,7 @@ func (g *GittufApp) handlePush(ctx context.Context, event *github.PushEvent) err
switch {
case strings.HasPrefix(ref, "refs/heads"):
refSpec := fmt.Sprintf("%s:refs/gittuf/local-ref", ref)
if err := gitRepo.FetchRefSpec("origin", []string{refSpec}, gitinterface.WithFetchDepth(1)); err != nil {
if err := gitRepo.FetchRefSpec("origin", []string{refSpec}); err != nil {
log.Default().Printf("Unable to fetch pushed branch: %v", err)
return err
}
Expand Down Expand Up @@ -374,7 +373,7 @@ func (g *GittufApp) handlePullRequest(ctx context.Context, event *github.PullReq
if err != nil {
return err
}
if _, err := git.PlainClone(localDirectory, false, &git.CloneOptions{URL: cloneURL, Depth: 1, ReferenceName: plumbing.ReferenceName(baseRef)}); err != nil {
if _, err := git.PlainClone(localDirectory, false, &git.CloneOptions{URL: cloneURL, ReferenceName: plumbing.ReferenceName(baseRef)}); err != nil {
log.Default().Printf("Unable to clone repository: %v", err)
return err
}
Expand All @@ -391,7 +390,7 @@ func (g *GittufApp) handlePullRequest(ctx context.Context, event *github.PullReq
}

refSpec := fmt.Sprintf("refs/pull/%d/head:refs/pull/%d/head", pullRequestNumber, pullRequestNumber)
if err := gitRepo.FetchRefSpec("origin", []string{refSpec}, gitinterface.WithFetchDepth(1)); err != nil {
if err := gitRepo.FetchRefSpec("origin", []string{refSpec}); err != nil {
log.Default().Printf("Unable to fetch feature branch: %v", err)
return err
}
Expand Down Expand Up @@ -455,7 +454,7 @@ func (g *GittufApp) handlePullRequest(ctx context.Context, event *github.PullReq
// Run this check in a separate goroutine for each
// affected PR
refSpec := fmt.Sprintf("refs/pull/%d/head:refs/pull/%d/head", pullRequest.GetNumber(), pullRequest.GetNumber())
if err := gitRepo.FetchRefSpec("origin", []string{refSpec}, gitinterface.WithFetchDepth(1)); err != nil {
if err := gitRepo.FetchRefSpec("origin", []string{refSpec}); err != nil {
log.Default().Printf("Unable to fetch feature branch for affected pull request %d: %v", pullRequest.GetNumber(), err)
return
}
Expand Down Expand Up @@ -635,7 +634,7 @@ func (g *GittufApp) handlePullRequestReview(ctx context.Context, event *github.P
if err != nil {
return err
}
if _, err := git.PlainClone(localDirectory, false, &git.CloneOptions{URL: cloneURL, Depth: 1, ReferenceName: plumbing.ReferenceName(baseRef)}); err != nil {
if _, err := git.PlainClone(localDirectory, false, &git.CloneOptions{URL: cloneURL, ReferenceName: plumbing.ReferenceName(baseRef)}); err != nil {
log.Default().Printf("Unable to clone repository: %v", err)
return err
}
Expand All @@ -655,7 +654,7 @@ func (g *GittufApp) handlePullRequestReview(ctx context.Context, event *github.P
// We fetch using github's refs/pull/<number>/head ref as the feature ref
// may be from a different repository
refSpec := fmt.Sprintf("refs/pull/%d/head:refs/pull/%d/head", pullRequestNumber, pullRequestNumber)
if err := gitRepo.FetchRefSpec("origin", []string{refSpec}, gitinterface.WithFetchDepth(1)); err != nil {
if err := gitRepo.FetchRefSpec("origin", []string{refSpec}); err != nil {
log.Default().Printf("Unable to fetch feature branch: %v", err)
return err
}
Expand Down
Loading