Skip to content

fix: changing debounce behaviour, adding preventDefault to event on search input #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GabhenDM wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: changing debounce behaviour, adding preventDefault to event on search input #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/projects/Projects.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Copyright (c) 2021, Marcelo Jorge Vieira
// Licensed under the BSD 3-Clause License

import React, { useState, useEffect, useCallback } from "react";
import React, { useState, useEffect, useMemo } from "react";
import { Link } from "react-router-dom";
import { makeStyles } from "@material-ui/core/styles";
import Pagination from "@material-ui/lab/Pagination";
Expand Down Expand Up @@ -67,13 +67,14 @@ const Projects = () => {
setPage(value);
fetchData({ query: { page: value, q: searchInput } });
};
const debouncedSearch = useCallback(
const debouncedSearch = useMemo(
() => debounce((value) => fetchData({ query: { page, q: value } }), 500),
[page]
);
const handleChangeSearch = (value) => {
setSearchInput(value);
debouncedSearch(value);
const handleChangeSearch = (event) => {
event.preventDefault();
setSearchInput(event.target.value);
debouncedSearch(event.target.value);
};
const [rows, setData] = useState({});
const [meta, setMeta] = useState({});
Expand Down Expand Up @@ -104,7 +105,7 @@ const Projects = () => {
<Input
placeholder="Find a project..."
value={searchInput}
onChange={(e) => handleChangeSearch(e.target.value)}
onChange={(e) => handleChangeSearch(e)}
/>
</form>
</div>
Expand Down