Skip to content

🐛 Keyboard shortcuts don't work on session resume#1219

Open
tcatlas wants to merge 1 commit into
gnmyt:mainfrom
tcatlas:bugs/shortcuts-on-resume
Open

🐛 Keyboard shortcuts don't work on session resume#1219
tcatlas wants to merge 1 commit into
gnmyt:mainfrom
tcatlas:bugs/shortcuts-on-resume

Conversation

@tcatlas
Copy link
Copy Markdown
Collaborator

@tcatlas tcatlas commented Mar 3, 2026

📋 Description

When a session resumes, either due to page refresh or other timeout, keyboard shortcuts no longer work. This PR updates guacamole connection handling so keyboard shortcut dispatch always targets the current client after a reconnect.

  • When connecting, immediately register the active guacamole client (including when an existing client is reused) so guacamoleRefs stays current for shortcut/snippet sends.
  • On teardown, clear the registered client reference alongside tunnel cleanup to avoid stale mappings.

🚀 Changes made to ...

  • 🔧 Server
  • 🖥️ Client
  • 📚 Documentation
  • 🔄 Other: ___

✅ Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have looked for similar pull requests in the repository and found none
  • This pull request does not contain translations (translations are managed through Crowdin)

🔗 Related Issues

None

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 3, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@tcatlas
Copy link
Copy Markdown
Collaborator Author

tcatlas commented Mar 3, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant