Security: WebSocket authentication token exposed in URL query string#1327
Open
tomaioo wants to merge 1 commit into
Open
Security: WebSocket authentication token exposed in URL query string#1327tomaioo wants to merge 1 commit into
tomaioo wants to merge 1 commit into
Conversation
The state-stream WebSocket URL includes `sessionToken` as a query parameter. Query-string tokens are commonly logged by reverse proxies, load balancers, browser/network tooling, and server access logs, increasing credential exposure risk. If leaked, this token can be replayed to hijack sessions. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: WebSocket authentication token exposed in URL query string
Problem
Severity:
High| File:client/src/common/hooks/useStateStream.js:L22The state-stream WebSocket URL includes
sessionTokenas a query parameter. Query-string tokens are commonly logged by reverse proxies, load balancers, browser/network tooling, and server access logs, increasing credential exposure risk. If leaked, this token can be replayed to hijack sessions.Solution
Avoid placing long-lived auth tokens in URLs. Use secure HttpOnly cookies for WebSocket auth, or exchange the session token for a short-lived, single-use WS token before connecting. Ensure server-side logs redact sensitive query parameters if unavoidable.
Changes
client/src/common/hooks/useStateStream.js(modified)