cut ci time by fixing the windows shell-timeout hang#107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The windows
testjob took ~20 min because a shell command hit its timeout but the child process tree survived, keeping a pipe open and stalling the test runner for ~999s. This kills the process tree on windows (mirroring the existing unix path), trims debug info to line tables to speed builds and shrink the cache, and adds CI hygiene (cancel superseded runs, save cache only on main).Verification
cargo fmt --all --check— passedcargo clippy --workspace --all-targets -- -D warnings— passedcargo test --workspace— passed (115 test binaries ok, 0 failed)taskkillpath is exercised only on the windows runner; local verification ran on macOS