fix: abort process reader/waiter tasks on cleanup to prevent hang#110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProcessRegistryspawned reader/waiter tasks without keeping theirJoinHandles, so if a group kill raced or missed, a leaked child kept those tasks (and its inherited stdout/stderr pipes) alive — stalling process shutdown. This was the root cause of the intermittent 48-minute CI hang ontest (ubuntu-latest)and the Windowsstdin_write_reaches_processfailure (findstrnever echoes until stdin EOF).Task handles are now stored on
Entryand aborted on drop;killalso closes stdin to send EOF;shutdown_alldrains entries to guarantee cleanup. Addsshutdown_all_terminates_running_processesas a regression test.Verification
cargo test -p goat-agent— passed (110 tests)cargo clippy --workspace --all-targets -- -D warnings— passedcargo fmt --all --check— passedsleep 30processes after kill/shutdown tests — verified