Open
Conversation
... to their latest versions. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Using @master is more prone to some breakage. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Use "oldstable" (currently 1.24) and "stable" (currently 1.25) aliases, so we always test the supported Go versions. Drop the 1.21, 1.22, and 1.23 from the matrix as they are no longer maintained / supported. Keep the 1.20 as this is the minimal version which is supposed to work, according to our go.mod. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This job depends on every other one, and thus makes it easier to set up "required" jobs in GHA CI (once this is merged, we only need "all-done" tas required). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Contributor
Author
|
@guelfey PTAL 🙏 Among the other things, will allow to have a single "required" job for this repo (the "all-done" one). |
Contributor
Author
|
@guelfey PTAL |
This comment was marked as outdated.
This comment was marked as outdated.
guelfey
reviewed
Mar 31, 2026
| - uses: codespell-project/actions-codespell@v2 | ||
|
|
||
| all-done: | ||
| runs-on: ububtu-24.04 |
| fail-fast: false | ||
| matrix: | ||
| go-version: ['1.20', '1.21', '1.22', '1.23'] | ||
| go-version: ['1.20', oldstable, stable] |
Member
There was a problem hiding this comment.
This means we don't explicitly need to bump to 1.26 though as this is now stable? I like it - I see the risk of the build breaking when a new Go version is released very low (but if it indeed happens, I want to know early). And keeping 1.20 in there also lets us know if we for some reason accidentally increase the minimum version requirement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this currently includes #419 and #421 and is therefore a draft (will rebase once those are merged).This bumps various CI bits and pieces to their latest versions. See individual commits for details.