replace commands that use Run to use RunE#679
replace commands that use Run to use RunE#679bhavyaKhatri2703 wants to merge 26 commits intogoharbor:mainfrom
Conversation
24f5850 to
f13e913
Compare
|
@bhavyaKhatri2703 I see your commit messages. it's looking good, but follow ig dont need for this PR but do consider it in the upcoming PRs |
|
understood thanks for sharing @rshdhere |
|
can someone help me with these checks? |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #679 +/- ##
=========================================
- Coverage 10.99% 7.80% -3.19%
=========================================
Files 173 270 +97
Lines 8671 13166 +4495
=========================================
+ Hits 953 1028 +75
- Misses 7612 12025 +4413
- Partials 106 113 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
So right now, lint is failing. Which probably will be fixed if you run this |
|
Also, could you remove changes to the artifact directory? It seems to have some different format errors as well. |
done |
done |
bupd
left a comment
There was a problem hiding this comment.
@bhavyaKhatri2703 please resolve conflicts
Thanks for the contribution.
@bupd resolved, thanks I think lint is failing maybe because of issues in main |
|
@bhavyaKhatri2703 lint issue in main is fixed - please resolve conflicts Thanks for the contribution |
bupd
left a comment
There was a problem hiding this comment.
please rebase onto main
Thanks
Signed-off-by: bhavyakhatri2703 <khatribhavya2703@gmail.com>
Signed-off-by: bhavyakhatri2703 <khatribhavya2703@gmail.com>
Signed-off-by: bhavyakhatri2703 <khatribhavya2703@gmail.com>
Signed-off-by: bhavyakhatri2703 <khatribhavya2703@gmail.com>
Signed-off-by: bhavyakhatri2703 <khatribhavya2703@gmail.com>
Signed-off-by: bhavyakhatri2703 <khatribhavya2703@gmail.com>
Signed-off-by: bhavyakhatri2703 <khatribhavya2703@gmail.com>
76761fc to
71bf620
Compare
Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>
Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>
Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>
Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>
Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>
|
@bupd pls have a look now , thanks. |
bupd
left a comment
There was a problem hiding this comment.
Looks like irrelevant doc changes have been made please fix that
Thanks
Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>
Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>
Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>
Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>
Signed-off-by: Bhavya Khatri <khatribhavya2703@gmail.com>
|
can someone help me with docs generation? When i try to revert them back manually lints get failed. |
|
@bhavyaKhatri2703 let the doc changes be, just run |
Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>
Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>
|
@bupd let me know if there are still unwanted changes? |
Signed-off-by: Prasanth Baskar <bupdprasanth@gmail.com>
bupd
left a comment
There was a problem hiding this comment.
Please fix the ci - test-code pipeline is failing
otherwise LGTM
@bhavyaKhatri2703 Thanks for the contribution
Signed-off-by: bhavyaKhatri2703 <khatribhavya2703@gmail.com>
fixed now. |

fixes #675
replaced older commands from Run to RunE with errors being returned properly instead of jusing log.