[codex] fix Gemini default_api tool calls#24
Draft
gold-silver-copper wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Gemini tool-call handling around malformed
default_apioutputs and Gemini 3 function-call correlation.functionCall.idthrough RigToolCall.call_idand send matchingfunctionResponse.idback in history.default_api.<declared_tool>/default_api:<declared_tool>wrappers, while rejecting baredefault_api, unknown tools, markdowntool_codeleakage, and unexpected code-execution parts.ToolNotFoundErrorinto a successful tool-result string.Root Cause
Gemini can sometimes emit malformed or non-contractual tool-use output involving
default_api. Rig was allowing unknown tool calls to reach the tool server, then stringifyingToolNotFoundErrorinto a normal tool result, which could poison the follow-up turn and end with a confusing empty response.Validation
cargo fmt --checkcargo test -p rig-core prompt_requestcargo test -p rig-core geminicargo test -p rig-core --libcargo clippy -p rig-core --all-targets --all-featurescargo test --test geminigit diff --checkNote:
cargo test -p rig-coreruns the lib tests successfully but still fails in an unrelated existing Anthropic doctest that importsrig::...from insiderig-core.