test(makernote): add integration tests for MakerNote detection (#15)#42
Open
test(makernote): add integration tests for MakerNote detection (#15)#42
Conversation
Add comprehensive integration tests for the MakerNote registry: - Detection tests for all manufacturers (Nikon, Sony, Fujifilm, Canon) - Detection order/priority verification - Malformed header handling - Boundary condition tests - Concurrent detection safety - Benchmarks for detection performance Tests verify: - Nikon Type 1 and Type 3 format detection - Sony DSC/CAM header detection - Fujifilm header and offset parsing - Canon IFD fallback detection - Unknown manufacturer handling - Thread safety of registry operations Benchmark results show fast detection (~300-600ns) with minimal allocations (1 alloc per detect, 0 for unknown). Partial work on #15 (MakerNote integration tests) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Coverage
Benchmarks
Test plan
make buildand CLI testingPartial work on #15 - remaining items: fuzz tests, per-manufacturer parse benchmarks
🤖 Generated with Claude Code