fix: PHPStan failing on older dependencies

[autaut03]

No description provided.

[github-actions]

🎉 This PR is included in version 2.5.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[dpi]

Ah I see. Given this is auto detected, and there isn’t a specific req, do you think if someone with a lower version of Stan requires this library they will run into issues?

Do we need a conflict less-than constraint entry here?

[autaut03]

do you think if someone with a lower version of Stan requires this library they will run into issues?

Could be. I should note that it's still possible to disable the extension, even if auto detected, through composer config:

{
  "extra": {
    "phpstan/extension-installer": {
      "ignore": ["good-php/reflection"]
    }
  }
}

Although for some reason PHPStan docs state that this is impossible 🤔

I don't like the idea of having to install a separate phpstan extension (I certainly wouldn't in this case), but it seems that your suggestion might have been a wiser idea - because in a separate package it would have been possible to just do "require": {"phpstan/phpstan": "^2.0"} and not worry about anything else.

That said, conflict might be exactly the solution it seems like

[autaut03]

Hm, the problem with conflict is that it wouldn't allow installation of the entire reflection package, even if the problem is just with the phpstan extension. Not sure if it's worth it 🤔

I'll add a docs entry about ignoring the extension for now.