-
Notifications
You must be signed in to change notification settings - Fork 380
fix: add missing spaces in multiline string concatenations #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: add missing spaces in multiline string concatenations #147
Conversation
Fix missing whitespace characters in Field description strings that use implicit string concatenation across multiple lines. - payment_receipt.py: "ISO 8601format." → "ISO 8601 format." - payment_request.py: "useto process" → "use to process" - payment_request.py: "paymentmethod." → "payment method." Python concatenates adjacent string literals without adding spaces, so explicit spaces are required at line boundaries. Signed-off-by: Hwangjae Lee <meetrick@gmail.com>
Summary of ChangesHello @meetrick, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a minor but important formatting issue in Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes issues with missing spaces in multiline string concatenations in pydantic field descriptions. The changes are straightforward and resolve the bugs. I've added a couple of minor suggestions to improve the consistency of how multiline strings are formatted, which is a common convention and can enhance readability.
src/ap2/types/payment_receipt.py
Outdated
| "The date and time the payment receipt was created, in ISO 8601" | ||
| "format." | ||
| " format." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability and to follow a common convention, it's often clearer to place the space at the end of the line that is being continued, rather than at the beginning of the next line.
| "The date and time the payment receipt was created, in ISO 8601" | |
| "format." | |
| " format." | |
| "The date and time the payment receipt was created, in ISO 8601 " | |
| "format." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it.
meetrick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied it
Signed-off-by: Hwangjae Lee <meetrick@gmail.com>
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.Summary
Fix missing whitespace characters in
Fielddescription strings that use implicit Python string concatenation across multiple lines.Changes
payment_receipt.py"ISO 8601format.""ISO 8601 format."payment_request.py"useto process""use to process"payment_request.py"paymentmethod.""payment method."Root Cause
Python automatically concatenates adjacent string literals without adding spaces between them. Explicit spaces are required at line boundaries when using parentheses for multiline strings.
Fixes #<issue_number_goes_here> 🦕