-
Notifications
You must be signed in to change notification settings - Fork 380
fix: Add missing run.sh script for x402 sample #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: Add missing run.sh script for x402 sample #158
Conversation
The x402 human-present scenario was missing a run.sh script, requiring users to invoke cards/run.sh with --payment-method flag. This adds a dedicated run.sh that defaults to X402 and updates the README to reference it. Closes google-agentic-commerce#107
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @Ayush10, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the developer experience for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a dedicated run.sh script for the x402 sample, aligning it with the structure of other samples and simplifying the execution process. The changes also include updating the README.md to reflect this new script. The implementation is solid, but I have a couple of minor suggestions for the new shell script to enhance its robustness by following shell scripting best practices.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Thanks for the review! The first suggestion (quoting |
Summary
run.shscript tosamples/python/scenarios/a2a/human-present/x402/withPAYMENT_METHOD="X402"as the default, matching the pattern of the existingcards/run.sh.README.mdexecution instructions to reference the new local script instead ofcards/run.sh --payment-method x402.Closes #107
Test plan
samples/python/scenarios/a2a/human-present/x402/run.shand verify all agents start withPAYMENT_METHOD=X402cards/run.sh --payment-method x402