Skip to content

Remove problematic decoding unit test #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulb777 merged 4 commits into from
Mar 5, 2026
Merged

Remove problematic decoding unit test #166

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7744702
Fix decoding error
paulb777 Mar 5, 2026
c4aa900
style
paulb777 Mar 5, 2026
32a7b7a
Remove problematic test instead
paulb777 Mar 5, 2026
2c64ac1
Restore changelog
paulb777 Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 0 additions & 32 deletions GoogleDataTransport/GDTCORTests/Unit/GDTCORMetricsMetadataTest.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,36 +108,4 @@ - (void)testSecureCoding {
XCTAssertEqualObjects(decodedMetricsMetadata, metricsMetadata);
}

- (void)testSecureCoding_WhenEncodingIsCorrupted {
// Given
// - Create an invalid instance and write its encoding to a file. When
// decoding, the invalid encoding should be treated as a corrupt encoding.
GDTCORMetricsMetadata *corruptedMetadata =
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wincompatible-pointer-types"
[GDTCORMetricsMetadata metadataWithCollectionStartDate:@"date"
logSourceMetrics:[GDTCORLogSourceMetrics metrics]];
#pragma clang diagnostic pop

NSError *encodeError;
NSData *encodedMetricsMetadata = GDTCOREncodeArchive(corruptedMetadata, nil, &encodeError);
XCTAssertNil(encodeError);
XCTAssertNotNil(encodedMetricsMetadata);

NSString *filePath = [NSTemporaryDirectory() stringByAppendingPathComponent:@"metadata.dat"];
NSError *writeError;
BOOL writeResult = GDTCORWriteDataToFile(encodedMetricsMetadata, filePath, &writeError);
XCTAssertNil(writeError);
XCTAssertTrue(writeResult);

// When
NSError *decodeError;
GDTCORMetricsMetadata *decodedMetricsMetadata =
(GDTCORMetricsMetadata *)GDTCORDecodeArchiveAtPath(GDTCORMetricsMetadata.class, filePath,
&decodeError);
// Then
XCTAssertNotNil(decodeError);
XCTAssertNil(decodedMetricsMetadata);
}

@end
Loading