Make cvd login display help text on invalid invocations#2211
Open
cjreynol wants to merge 3 commits intogoogle:mainfrom
Open
Make cvd login display help text on invalid invocations#2211cjreynol wants to merge 3 commits intogoogle:mainfrom
cvd login display help text on invalid invocations#2211cjreynol wants to merge 3 commits intogoogle:mainfrom
Conversation
Include whether the request is over SSH in `Oauth2ConsentRequest`. That information is used alongside those fields. This also makes it easier to push the flag parsing into a helper out of `CvdLoginCommand::Handle`.
To simplify the `Handle` method.
If all of the necessary flags are not provided, display the help text to guide the user towards the correct usage. Bug: 487846108
cjreynol
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
Databean
approved these changes
Mar 3, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If all of the necessary flags are not provided, display the help text to guide the user towards the correct usage.
Bug: 487846108