Skip to content

Remove pytype hack for the ContextStack typing annotations #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove pytype hack for the ContextStack typing annotations #704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions etils/edc/stack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
from __future__ import annotations

import dataclasses
import typing
from typing import Generic, TypeVar

from etils.edc import context
Expand Down Expand Up @@ -54,12 +53,7 @@ def my_thread_safe_contextmanager():
```
"""

if typing.TYPE_CHECKING:
stack: list[_T] = dataclasses.field(default_factory=list)
else:
stack: context.ContextVar[list[_T]] = dataclasses.field(
default_factory=list
)
stack: context.ContextVar[list[_T]] = dataclasses.field(default_factory=list)

def append(self, value: _T) -> None:
"""Append a value to the stack."""
Expand Down