Skip to content

Remove hardcoded 0x777 file mode #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove hardcoded 0x777 file mode #713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions etils/epath/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ def makedirs(
exist_ok: bool = False,
mode: Optional[int] = None,
) -> None:
if mode is not None and mode != 0o777:
if mode is not None and mode != 0o750:
# tf.io.gfile do not support setting `mode=`
raise NotImplementedError(
'makedirs with custom `mode=` not supported for tf.io.gfile backend.'
Expand All @@ -328,7 +328,7 @@ def mkdir(
exist_ok: bool = False,
mode: Optional[int] = None,
) -> None:
if mode is not None and mode != 0o777:
if mode is not None and mode != 0o750:
# tf.io.gfile do not support setting `mode=`
raise NotImplementedError(
'mkdir with custom `mode=` not supported for tf.io.gfile backend.'
Expand Down Expand Up @@ -484,7 +484,7 @@ def makedirs(
exist_ok: bool = False,
mode: Optional[int] = None,
) -> None:
if mode is not None and mode != 0o777:
if mode is not None and mode != 0o750:
# FileSystemSpec backend do not support setting `mode=`
raise NotImplementedError(
'makedirs with custom `mode=` not supported for FileSystemSpec'
Expand All @@ -499,7 +499,7 @@ def mkdir(
exist_ok: bool = False,
mode: Optional[int] = None,
) -> None:
if mode is not None and mode != 0o777:
if mode is not None and mode != 0o750:
# FileSystemSpec backend do not support setting `mode=`
raise NotImplementedError(
'mkdir with custom `mode=` not supported for FileSystemSpec backend.'
Expand Down