Skip to content

Fix as_np_dtype to check numpy/jax dtypes before torch dtypes #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Mar 15, 2026
Merged

Fix as_np_dtype to check numpy/jax dtypes before torch dtypes #787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions etils/enp/numpy_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,13 +174,15 @@ def is_dtype(self, dtype) -> bool:
)

def as_np_dtype(self, dtype):
if self.is_tf_dtype(dtype):
if self.is_np_dtype(dtype) or self.is_jax_dtype(dtype):
pass
elif self.is_tf_dtype(dtype):
dtype = dtype.as_numpy_dtype
elif self.is_torch_dtype(dtype):
from etils.enp import compat # pylint: disable=g-import-not-at-top

dtype = compat.dtype_torch_to_np(dtype)
elif not self.is_jax_dtype(dtype) and not self.is_np_dtype(dtype):
else:
raise TypeError(f'Invalid dtype: {dtype!r}')
return np.dtype(dtype)

Expand Down
Loading