Refactor JobDialogComponent to use shared TaskEditorComponent

[gino-m]

Fxies #2408

[gemini-code-assist]

Summary of Changes

Hello @gino-m, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the modularity and reusability of the application's task editing functionality. By extracting the task editing logic into a dedicated, shared TasksEditorComponent, the JobDialogComponent becomes much cleaner and easier to maintain. This refactoring consolidates task management into a single, well-defined component, promoting consistency and reducing code duplication across the application.

Highlights

• Refactor JobDialogComponent: The JobDialogComponent has been refactored to delegate all task editing responsibilities to a new, shared TasksEditorComponent.
• Introduction of shared TasksEditorComponent: The previous inline task editing UI and logic within JobDialogComponent's template and TypeScript file have been replaced by a single, reusable <tasks-editor> component.
• Removal of redundant components: The task-editor and option-editor components, along with their associated files (HTML, SCSS, TS, spec, module), have been removed as their functionality is now encapsulated within the new shared TasksEditorComponent.
• Simplified JobDialogComponent logic: The JobDialogComponent's TypeScript file has been significantly streamlined by removing methods related to task management (e.g., addQuestion, onTaskDelete, onTaskUpdate, validation helpers) which are now handled by the TasksEditorComponent.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a great refactoring that replaces the local task editor implementation within JobDialogComponent with a new shared TasksEditorComponent. This significantly simplifies JobDialogComponent by removing a large amount of code and delegating task management responsibilities. The changes are well-executed, leading to cleaner and more maintainable code. I've included a few minor suggestions to further improve code style and readability.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 4.72441% with 121 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.63%. Comparing base (f5b4b72) to head (b0ba24a).

Files with missing lines	Patch %	Lines
.../src/app/services/data-store/data-store.service.ts	1.81%	108 Missing ⚠️
...ainer/main-page/job-dialog/job-dialog.component.ts	0.00%	8 Missing ⚠️
web/src/app/services/auth/auth.service.ts	28.57%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2409      +/-   ##
==========================================
+ Coverage   59.26%   59.63%   +0.36%     
==========================================
  Files         115      111       -4     
  Lines        2872     2767     -105     
  Branches      430      404      -26     
==========================================
- Hits         1702     1650      -52     
+ Misses       1110     1059      -51     
+ Partials       60       58       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[gino-m]

@rfontanarosa Can you please confirm your recent fix was also correctly applied here?