runsc/cgroup/systemd.go: improve systemd version error diagnostics #12380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Wraps and propagates the underlying DBus error when querying the systemd version instead of returning a generic error string. This makes sporadic startup failures easier to diagnose. Need to confirm before continuing to add the proposed "fallback to an environment read, or allowing that as an override".
hexatedjuice
force-pushed
the
systemd-version-dbus-wrap
branch
from
2587f95 to
d551658
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wraps and propagates the underlying DBus error when querying the systemd version instead of returning a generic error string.
This makes sporadic startup failures easier to diagnose. Need to confirm before continuing to add the proposed "fallback to an environment read, or allowing that as an override".
Begin to address #11877.