Skip to content

test: add unit tests for utils/math_utils.py#1165

Open
kbhujbal wants to merge 2 commits intogoogle:mainfrom
kbhujbal:test/add-math-utils-tests
Open

test: add unit tests for utils/math_utils.py#1165
kbhujbal wants to merge 2 commits intogoogle:mainfrom
kbhujbal:test/add-math-utils-tests

Conversation

@kbhujbal
Copy link

The math_utils module provides LaTeX answer extraction, normalization, and symbolic grading logic used by RL reward computation but had no test coverage. This adds comprehensive parameterized tests covering mathd_normalize_answer, extract_boxed_answer, last_boxed_only_string, remove_boxed, split_tuple, grade_answer_sympy, are_equal_under_sympy, and internal helper functions.

Resolves #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

Reference

Colab Notebook

Checklist

  • I have added all the necessary unit tests for my change.
  • I have verified that my change does not break existing code and all unit tests pass.
  • I have added all appropriate doc-strings/documentation.
  • My PR is based on the latest changes of the main branch (if unsure, rebase the code).
  • I have signed the Contributor License Agreement.
  • I have followed Contribution Guidelines.

The math_utils module provides LaTeX answer extraction, normalization,
and symbolic grading logic used by RL reward computation but had no
test coverage. This adds comprehensive parameterized tests covering
mathd_normalize_answer, extract_boxed_answer, last_boxed_only_string,
remove_boxed, split_tuple, grade_answer_sympy, are_equal_under_sympy,
and internal helper functions.
@gemini-code-assist
Copy link

Summary of Changes

Hello @kbhujbal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the stability and correctness of the math_utils module by introducing a new, extensive suite of unit tests. These tests validate the module's core functionalities, which are crucial for LaTeX answer processing and symbolic grading in reward computation, thereby preventing regressions and ensuring reliable mathematical operations.

Highlights

  • Unit Test Coverage: Added comprehensive parameterized unit tests for various functions within tunix.utils.math_utils, including mathd_normalize_answer, extract_boxed_answer, last_boxed_only_string, remove_boxed, split_tuple, grade_answer_sympy, are_equal_under_sympy, and several internal helper functions.
  • Improved Code Reliability: Enhanced the robustness of the LaTeX answer extraction, normalization, and symbolic grading logic by introducing dedicated test cases, ensuring correct behavior for a wide range of inputs.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • tests/utils/math_utils_test.py
    • Added a new test file to provide comprehensive unit test coverage for the math_utils.py module.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@kbhujbal
Copy link
Author

  • Adds comprehensive unit tests for tunix/utils/math_utils.py which previously had zero test coverage
  • Covers 11 test classes with 80+ parameterized test cases for answer normalization, LaTeX extraction, symbolic grading, tuple splitting, and helper functions

Test plan

  • tests/utils/math_utils_test.py passes on CPU
  • No new dependencies required

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive set of unit tests for the math_utils.py module, significantly improving test coverage and code robustness. The tests are well-structured using parameterized.TestCase and cover a wide variety of functions and edge cases. I found one issue with an incorrect expected value in a test case, for which I've provided a specific comment and suggestion. Overall, this is a valuable addition to the project.

I've applied the suggested change from gemini code assist to fix the expected value in the multiple_spaces test case. The test now correctly reflects the current behavior of the regex logic. Ready for a final check!

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants