[hermes] Harden against weird symlink layout #3043
Conversation
gherrit-pr-id: Gtu5rhuk5rjkrhhqpfwbmniejgf57ogzn
Summary of ChangesHello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request significantly improves the path resolution logic within the hermes tool, specifically hardening it against issues arising from symlinks and complex module layouts. By introducing fs::canonicalize at critical points in resolve.rs and scanner.rs, the tool now correctly handles workspace roots and package paths, preventing incorrect comparisons and potential infinite loops (as demonstrated by the new cyclic_paths test fixture). Additionally, the module resolution logic in scanner.rs has been refined to correctly determine base directories for child modules based on Rust's mod.rs and file-named module conventions. The changes are well-implemented and include appropriate error handling and logging. The addition of new test fixtures thoroughly validates these improvements.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Gldfbyjdbfd3uolcvhjysepgbx472jv5a #3043 +/- ##
==================================================================
Coverage 91.87% 91.87%
==================================================================
Files 20 20
Lines 6057 6057
==================================================================
Hits 5565 5565
Misses 492 492 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
This PR is on branch hermes.
#[cfg_attr(..., path = "...")]#3045unsaferedaction #3034mod foo;declarations #3008Latest Update: v11 — Compare vs v10
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gtu5rhuk5rjkrhhqpfwbmniejgf57ogzn && git checkout -b pr-Gtu5rhuk5rjkrhhqpfwbmniejgf57ogzn FETCH_HEADCheckout
git fetch origin refs/heads/Gtu5rhuk5rjkrhhqpfwbmniejgf57ogzn && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gtu5rhuk5rjkrhhqpfwbmniejgf57ogzn && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.