chore: update dotnet monorepo to v10#738
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the versions of System.Text.Json and Microsoft.SourceLink.GitHub in the project files. The reviewer feedback highlights that the explicit reference to System.Text.Json is redundant for projects targeting .NET 10 and suggests aligning the target framework of the ADO.NET project with the updated package versions to maintain consistency across the repository.
| <PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="10.0.7"/> | ||
| <PackageReference Include="OpenTelemetry.Api" Version="1.15.3"/> | ||
| <PackageReference Include="System.Text.Json" Version="8.0.6"/> | ||
| <PackageReference Include="System.Text.Json" Version="10.0.7"/> |
There was a problem hiding this comment.
Since the project targets net10.0, System.Text.Json is already included in the .NET shared framework. Explicitly referencing the NuGet package is redundant and can lead to version conflicts or unnecessary dependency resolution overhead. Unless a specific patch version is required that is not yet part of the targeted SDK, this reference should be removed.
| <PackageReference Include="Google.Cloud.Spanner.V1" Version="5.12.0" /> | ||
| <PackageReference Include="Grpc.Net.Client" Version="2.76.0" /> | ||
| <PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All"/> | ||
| <PackageReference Include="Microsoft.SourceLink.GitHub" Version="10.0.203" PrivateAssets="All"/> |
There was a problem hiding this comment.
The update to Microsoft.SourceLink.GitHub version 10 aligns with the monorepo's move to .NET 10, but this project still targets net8.0 (line 4). This creates an inconsistency within the monorepo. Consider updating the TargetFramework to net10.0 to ensure all projects are aligned, unless maintaining .NET 8 support for this specific provider is intentional.
9362fe3 to
58ba6b4
Compare
This PR contains the following updates:
8.0.0→10.0.3008.0.6→10.0.8Release Notes
dotnet/dotnet (Microsoft.SourceLink.GitHub)
v10.0.300: .NET 10.0.8 / 10.0.300You can build .NET 10.0 from the repository by cloning the release tag
v10.0.300and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v10.0.204: .NET 10.0.8 / 10.0.204You can build .NET 10.0 from the repository by cloning the release tag
v10.0.204and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v10.0.203: .NET 10.0.7 / 10.0.203You can build .NET 10.0 from the repository by cloning the release tag
v10.0.203and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v10.0.202: .NET 10.0.6 / 10.0.202You can build .NET 10.0 from the repository by cloning the release tag
v10.0.202and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v10.0.201: .NET 10.0.5 / 10.0.201You can build .NET 10.0 from the repository by cloning the release tag
v10.0.201and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v10.0.200: .NET 10.0.4 / 10.0.200You can build .NET 10.0 from the repository by cloning the release tag
v10.0.200and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v10.0.108: .NET 10.0.8 / 10.0.108You can build .NET 10.0 from the repository by cloning the release tag
v10.0.108and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v10.0.107: .NET 10.0.7 / 10.0.107You can build .NET 10.0 from the repository by cloning the release tag
v10.0.107and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v10.0.106: .NET 10.0.6 / 10.0.106You can build .NET 10.0 from the repository by cloning the release tag
v10.0.106and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v10.0.105: .NET 10.0.5 / 10.0.105You can build .NET 10.0 from the repository by cloning the release tag
v10.0.105and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v10.0.104: .NET 10.0.4 / 10.0.104You can build .NET 10.0 from the repository by cloning the release tag
v10.0.104and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v10.0.103: .NET 10.0.3 / 10.0.103You can build .NET 10.0 from the repository by cloning the release tag
v10.0.103and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached is the PGP signature for the GitHub generated tarball. You can find the public key at https://dot.net/release-key-2023
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.