fix: defaultAwsSecurityCredentialSupplier fetches aws-credentials correctly from credential-url#901
Merged
vverman merged 3 commits intogoogleapis:mainfrom Feb 20, 2026
Merged
Conversation
…rectly from credential-url.
sofisl
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In issue #898 a customer was facing issues when IMDSV1 was disabled and only IMDSV2 was enabled.
This is because currently the request to the AWS credentials endpoint returns a string as a response:
But we were accessing its properties as if it were a json response which was returning a null value.
response.AccessKeyId<- This would return null.Now we make a call to get a json response, which can now be used to fetch the fields correctly:
P.S.: This was tested with the google-auth-lib 10.6.0 with the @google-cloud/storage.