impl(auth): move away from jsonwebtoken#4403
impl(auth): move away from jsonwebtoken#4403alvarowolfx wants to merge 13 commits intogoogleapis:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4403 +/- ##
==========================================
- Coverage 94.98% 94.85% -0.13%
==========================================
Files 192 192
Lines 7280 7373 +93
==========================================
+ Hits 6915 6994 +79
- Misses 365 379 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@coryan another take on this, now trying to move most of the crypto related stuff to rustls, but to read public certificates as DER I had to add others crate lower level crates - |
I am warming up to this idea. Can you explore if https://docs.rs/rustls-pki-types/latest/rustls_pki_types/struct.SubjectPublicKeyInfoDer.html |
I tried that too, but JWK key sets comes as a pair of prime numbers that can be used to derive the certificate key. Looks like the rustls-pki-types expect the cert to be already in DER/bytes format. But will try a bit more here. |
| @@ -71,7 +73,7 @@ mutants.workspace = true | |||
| default = ["default-idtoken-backend", "default-rustls-provider"] | |||
| # The `idtoken` feature enables support to create and validate OIDC ID Tokens. | |||
| # See the create top-level documentation for more information. | |||
There was a problem hiding this comment.
Since you are here, I just noticed a typo "create" -> "crate's"
Towards #3947