cleanup(pubsub): remove internal builders from public API#4524
Merged
haphungw merged 1 commit intogoogleapis:mainfrom Feb 5, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4524 +/- ##
=======================================
Coverage 95.01% 95.01%
=======================================
Files 195 195
Lines 7449 7449
=======================================
Hits 7078 7078
Misses 371 371 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PhongChuong
reviewed
Feb 3, 2026
Collaborator
PhongChuong
left a comment
There was a problem hiding this comment.
The changes LGTM but you may need to update the librarian version/regenerate the rest of the repo prior to this PR. It might be useful to check with the current on duty.
zashed
approved these changes
Feb 3, 2026
e4388bf to
557edef
Compare
557edef to
1832807
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
internal_buildersconfig in librarian.yaml to generatepub(crate)visibility for pubsub dataplane builders. This also removes the previous#[doc(hidden)]workaround used to avoiddoctestfailures.Fix #3959