Skip to content

cleanup(pubsub): remove internal builders from public API#4524

Merged
haphungw merged 1 commit intogoogleapis:mainfrom
haphungw:fix/remove-pubsub-internal-only-types-from-public-api
Feb 5, 2026
Merged

cleanup(pubsub): remove internal builders from public API#4524
haphungw merged 1 commit intogoogleapis:mainfrom
haphungw:fix/remove-pubsub-internal-only-types-from-public-api

Conversation

@haphungw
Copy link
Contributor

@haphungw haphungw commented Feb 3, 2026

Use internal_builders config in librarian.yaml to generate pub(crate) visibility for pubsub dataplane builders. This also removes the previous #[doc(hidden)] workaround used to avoid doctest failures.

Fix #3959

@haphungw haphungw requested a review from a team as a code owner February 3, 2026 06:39
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Feb 3, 2026
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.01%. Comparing base (14367c9) to head (1832807).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4524   +/-   ##
=======================================
  Coverage   95.01%   95.01%           
=======================================
  Files         195      195           
  Lines        7449     7449           
=======================================
  Hits         7078     7078           
  Misses        371      371           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@PhongChuong PhongChuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM but you may need to update the librarian version/regenerate the rest of the repo prior to this PR. It might be useful to check with the current on duty.

@haphungw haphungw force-pushed the fix/remove-pubsub-internal-only-types-from-public-api branch 3 times, most recently from e4388bf to 557edef Compare February 5, 2026 06:09
@haphungw haphungw force-pushed the fix/remove-pubsub-internal-only-types-from-public-api branch from 557edef to 1832807 Compare February 5, 2026 06:25
Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@haphungw haphungw merged commit 990a100 into googleapis:main Feb 5, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove pubsub internal-only types from public API

4 participants