fix: publish batch flow control metrics #2749
Open
+90
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
kongweihan
previously approved these changes
Jan 6, 2026
kongweihan
reviewed
Jan 6, 2026
...e/src/test/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsTracerTest.java
Show resolved
Hide resolved
kongweihan
previously approved these changes
Jan 6, 2026
product-auto-label
bot
added
size: m
mutianf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new batch flow control metrics writes to BigtableClient schema. Currently we have 2 otel instances that publishes the metrics:
external OTEL: this is set on the tracer factory so per request metrics are recorded on the external OTEL. It publishes to BigtableTable schema.
internal OTEL: this is set up on the channel to record connection level metrics. It publishes to BigtableClient schema. We needed a separate internal OTEL instance because for connection level metrics (e.g. grpc metrics), the bigtable resource (project id, instance id) needs to be hard coded on the exporter because it's not a metric label.
New batch flow control metrics is a per request metrics but it publishes to BigtableClient schema. This means we need to add plumbing on the internal OTEL to record per request metrics.