chore: librarian generate pull request: 20260325T155702Z#1525
chore: librarian generate pull request: 20260325T155702Z#1525
Conversation
product-auto-label
bot
added
the
api: spanner
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, generated by the Librarian CLI, updates the Google Cloud Spanner client library to incorporate several new features and documentation clarifications from recent proto changes. Key additions include enhanced client context capabilities, improved transaction management with cache updates and routing hints, and more granular autoscaling configurations. The update also refines various API comments and streamlines internal code structure and testing dependencies. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request primarily involves regenerating client libraries for google-cloud-spanner, leading to extensive refactoring of import statements across various Python files within the spanner_admin_database_v1, spanner_admin_instance_v1, and spanner_v1 modules. Key functional enhancements include new CPU utilization targets and disable options for Spanner instance autoscaling configurations, and the addition of a cache_update field to CommitResponse, ResultSet, and Transaction types to support location caching. Descriptions for RoutingHint and ReadLockMode have been clarified, and the ClientContext class has been refactored into RequestOptions. Testing configurations in noxfile.py and related test files were also updated. The review comments point out several instances of duplicate google.longrunning.operations_pb2 imports that should be removed for improved code clarity.
| from google.iam.v1 import iam_policy_pb2 # type: ignore | ||
| from google.iam.v1 import policy_pb2 # type: ignore | ||
| from google.longrunning import operations_pb2 # type: ignore | ||
| from google.longrunning import operations_pb2 # type: ignore |
There was a problem hiding this comment.
This import of google.longrunning.operations_pb2 is a duplicate of the one on the preceding line. Please remove it to improve code clarity.
| from google.iam.v1 import iam_policy_pb2 # type: ignore | ||
| from google.iam.v1 import policy_pb2 # type: ignore | ||
| from google.longrunning import operations_pb2 # type: ignore | ||
| from google.longrunning import operations_pb2 # type: ignore |
There was a problem hiding this comment.
This import of google.longrunning.operations_pb2 is a duplicate of the one on the preceding line. Please remove it to improve code clarity.
| from google.iam.v1 import iam_policy_pb2 # type: ignore | ||
| from google.iam.v1 import policy_pb2 # type: ignore | ||
| from google.longrunning import operations_pb2 # type: ignore | ||
| from google.longrunning import operations_pb2 # type: ignore |
There was a problem hiding this comment.
This import of google.longrunning.operations_pb2 is a duplicate of the one on the preceding line. Please remove it to improve code clarity.
| from google.iam.v1 import iam_policy_pb2 # type: ignore | ||
| from google.iam.v1 import policy_pb2 # type: ignore | ||
| from google.longrunning import operations_pb2 # type: ignore | ||
| from google.longrunning import operations_pb2 # type: ignore |
There was a problem hiding this comment.
This import of google.longrunning.operations_pb2 is a duplicate of the one on the preceding line. Please remove it to improve code clarity.
| from google.iam.v1 import options_pb2 # type: ignore | ||
| from google.iam.v1 import policy_pb2 # type: ignore | ||
| from google.longrunning import operations_pb2 # type: ignore | ||
| from google.longrunning import operations_pb2 # type: ignore |
There was a problem hiding this comment.
This import of google.longrunning.operations_pb2 is a duplicate of the one on the preceding line. Please remove it to improve code clarity.
| from google.iam.v1 import options_pb2 # type: ignore | ||
| from google.iam.v1 import policy_pb2 # type: ignore | ||
| from google.longrunning import operations_pb2 # type: ignore | ||
| from google.longrunning import operations_pb2 # type: ignore |
There was a problem hiding this comment.
This import of google.longrunning.operations_pb2 is a duplicate of the one on the preceding line. Please remove it to improve code clarity.
2 participants
PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.
BEGIN_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment in message
.google.spanner.v1.TransactionOptions.ReadWrite.ReadLockModeis changedPiperOrigin-RevId: 878019893
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@5c9602db
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
routing_hintin messages.google.spanner.v1.ResultSetand.google.spanner.v1.PartialResultSetare changedPiperOrigin-RevId: 878019893
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@5c9602db
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: include cache updates and routing hint into BeginTransaction and Commit request/response respectively
PiperOrigin-RevId: 878019893
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@5c9602db
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
transaction_tagin message.google.spanner.v1.RequestOptionsis changedPiperOrigin-RevId: 865546011
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@8d30990f
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
param_typesin message.google.spanner.v1.PartitionQueryRequestis changedPiperOrigin-RevId: 865546011
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@8d30990f
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: include cache updates into the ResultSet response
PiperOrigin-RevId: 865546011
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@8d30990f
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
paramsin message.google.spanner.v1.PartitionQueryRequestis changedPiperOrigin-RevId: 865546011
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@8d30990f
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
commit_timestampin message.google.spanner.v1.BatchWriteResponseis changedPiperOrigin-RevId: 865546011
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@8d30990f
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
chore: adjust initial_poll_delay for CreateDatabase and UpdateDatabaseDdl LRO operations
PiperOrigin-RevId: 853884590
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@136a2c43
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add a ClientContext field to Spanner requests
PiperOrigin-RevId: 853323071
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@211d22fa
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add Secure Parameters to the ClientContext
PiperOrigin-RevId: 853323071
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@211d22fa
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Exposing total CPU related fields in AutoscalingConfig
PiperOrigin-RevId: 845819318
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@6e20492a
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: Update high_priority_cpu_utilization_percent in AutoscalingConfig to be Optional and clarify its behavior when not specified
PiperOrigin-RevId: 845819318
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@6e20492a
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: minor update for Spanner Location API
PiperOrigin-RevId: 834841888
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@ded7ed1e
END_NESTED_COMMIT
END_COMMIT
This pull request is generated with proto changes between
googleapis/googleapis@a17b84ad
(exclusive) and
googleapis/googleapis@5c9602db
(inclusive).
Librarian Version: v1.0.2-0.20260309131826-42ac5c451239
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209