feat: expose DELETE_OBJECT in AsyncGrpcClient

[chandra-siri]

Expose DELETE_OBJECT in AsyncGrpcClient

[gemini-code-assist]

Summary of Changes

Hello @chandra-siri, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the foundational code for exposing metadata operations within the AsyncGrpcClient for Google Cloud Storage. The primary addition is an asynchronous delete_object method, which enables direct gRPC-based object deletion, supporting conditional operations based on object generation and metageneration. This change enhances the client's capability to interact with Google Cloud Storage at a lower level, providing more granular control over object lifecycle management.

Highlights

• New delete_object method: Implemented an asynchronous delete_object method in AsyncGrpcClient to support object deletion with various conditional parameters like generation, if_generation_match, and if_metageneration_match.
• System Test for Deletion: Added a system test (test_delete_object_using_grpc_client) to validate the functionality of the new delete_object method, including verification of object removal and handling of NotFound exceptions.
• Unit Test for Request Construction: Introduced a dedicated unit test (TestDeleteObject.test_delete_object) to ensure the correct construction of DeleteObjectRequest and proper invocation of the underlying gRPC client.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request introduces an async_grpc_client with a delete_object method and includes corresponding unit and system tests. The delete_object method correctly constructs the gRPC request. However, there are some inconsistencies and potential issues in the system test's usage of the new method and a minor documentation detail in the async_grpc_client's docstring. The example usage in async_grpc_client.py also has a minor issue with error re-raising.

[gemini-code-assist]

The docstring for test_delete_object_using_grpc_client is incorrect. It describes a test for overriding an existing object, not for deleting an object. Please update it to accurately reflect the purpose of this test.

Suggested change

	"""
	Test that a new writer when specifies `None` overrides the existing object.
	"""
	Test that `delete_object` using the gRPC client successfully deletes an object.
	"""