Skip to content
This repository was archived by the owner on Mar 13, 2018. It is now read-only.

Flick#50

Open
sbmaxx wants to merge 1 commit into
googlearchive:masterfrom
sbmaxx:flick
Open

Flick#50
sbmaxx wants to merge 1 commit into
googlearchive:masterfrom
sbmaxx:flick

Conversation

@sbmaxx

@sbmaxx sbmaxx commented Aug 28, 2014

Copy link
Copy Markdown
Contributor

Ported flick event from PolymerGestures

@dfreedm

dfreedm commented Sep 24, 2014

Copy link
Copy Markdown
Contributor

Same concerns as #49 (comment), then it just needs a rebase and I'll merge.

@sbmaxx sbmaxx force-pushed the flick branch 2 times, most recently from 163a279 to d51eeef Compare September 25, 2014 05:14
@sbmaxx

sbmaxx commented Sep 25, 2014

Copy link
Copy Markdown
Contributor Author

Did rebase from master, squash. Added defaultAction = none, _source = flick

@kevinwestern

Copy link
Copy Markdown

@sbmaxx Did you mean to close this? It would be nice to have this gesture.

@sbmaxx

sbmaxx commented Dec 29, 2014

Copy link
Copy Markdown
Contributor Author

I want this to be merged ;)

@sbmaxx

sbmaxx commented Jan 29, 2015

Copy link
Copy Markdown
Contributor Author

ping :)

@steida

steida commented Jan 29, 2015

Copy link
Copy Markdown
Contributor

This project seems to be dead.

@sbmaxx

sbmaxx commented Jan 29, 2015

Copy link
Copy Markdown
Contributor Author

@steida so, what we should use for touch-gestures? :)

@steida

steida commented Jan 29, 2015

Copy link
Copy Markdown
Contributor

http://hammerjs.github.io/ looks promising.

defaultsAction & source to flick
@sbmaxx

sbmaxx commented Mar 31, 2015

Copy link
Copy Markdown
Contributor Author

just for the history. PR was opened at 28th august, 2014. ;)

@steida

steida commented Mar 31, 2015

Copy link
Copy Markdown
Contributor

They even have no balls to officially kill this project like Angular has killed itself. Unbelievable, I remember better Google. Now everything interesting comes from Facebook engineering. Good to know.

@sbmaxx

sbmaxx commented Apr 1, 2015

Copy link
Copy Markdown
Contributor Author

Last commit to hammer.js was on Oct 25, 2014 :/ All projects about touch-events/gestures will be dead sooner or later :)

@picitujeromanov

Copy link
Copy Markdown

i've tried hammer.js for a rather complex layout but switched to polymer gestures instead ... there's no way how to prevent event from bubbling in hammer, and you can't listen for 'down' events only ... when you call stopPropagation on a tap, you're actually stopping 'up' event, but the 'down' event was already caught on your parent which just messes things up. Also features like hammers 'requireFailure' are hard to use in angular environment. Only thing that i've borrowed from hammer (and created directive for it) is how they apply css properties (touch-action etc...) to elements on which it is applied to

@DimitryDushkin

Copy link
Copy Markdown

@picitujeromanov in hammer.js the best way to handle events is to handle them on top layer and route these events to inner elements depending on e.currentTarget.
I had similar problems with hammer.js, but this trick did job well.

@steida steida mentioned this pull request Apr 2, 2015
@sbmaxx sbmaxx mentioned this pull request Oct 20, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants