fix(date): fix endOf week date functionality#444
Open
TheCaffinatedDeveloper wants to merge 1 commit intogorules:masterfrom
Open
fix(date): fix endOf week date functionality#444TheCaffinatedDeveloper wants to merge 1 commit intogorules:masterfrom
TheCaffinatedDeveloper wants to merge 1 commit intogorules:masterfrom
Conversation
… of chrono::num_days_from_sunday
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix endOf('week') to return the correct Sunday for all weekdays. The previous implementation used the wrong weekday offset, which caused incorrect results for some inputs.
This updates the week-end calculation to align with the documented Monday-to-Sunday week semantics and adds regression coverage for start/end-of-period behavior based on the date examples in the docs: docs.gorules.io/learn/zen-language/dates#start-and-end-of-periods.
References #443.